remove old observer before changing user

This commit is contained in:
Arnaud Vergnet 2020-12-16 11:13:04 +01:00
parent f544711bfb
commit 6f1bd41cc9

View file

@ -5,6 +5,7 @@ import javafx.fxml.FXML;
import javafx.fxml.Initializable;
import javafx.scene.shape.Circle;
import java.beans.PropertyChangeEvent;
import java.net.URL;
import java.util.ResourceBundle;
@ -12,28 +13,38 @@ public class UserActiveIndicatorController implements Initializable {
@FXML
private Circle circle;
private PeerUser user;
@Override
public void initialize(URL location, ResourceBundle resources) {
}
private void updateState(PeerUser user) {
circle.getStyleClass().clear();
if (user.isActive()) {
circle.getStyleClass().add("active-user-dot");
} else {
circle.getStyleClass().add("inactive-user-dot");
private void updateState() {
if (user != null) {
circle.getStyleClass().clear();
if (user.isActive()) {
circle.getStyleClass().add("active-user-dot");
} else {
circle.getStyleClass().add("inactive-user-dot");
}
}
}
private void onStateChange(PropertyChangeEvent propertyChangeEvent) {
if (propertyChangeEvent.getPropertyName().equals("state")) {
updateState();
}
}
public void setUser(PeerUser user) {
user.addObserver(propertyChangeEvent -> {
if (propertyChangeEvent.getPropertyName().equals("state")) {
updateState(user);
}
});
updateState(user);
if (this.user != null) {
// remove old observer before setting new user
this.user.removeObserver(this::onStateChange);
}
this.user = user;
user.addObserver(this::onStateChange);
updateState();
}
public void setSize(double value) {