Fixed tab bar icon not updating on theme change

This commit is contained in:
Arnaud Vergnet 2020-05-01 11:06:37 +02:00
parent eda9edd21c
commit cb522466c7

View file

@ -31,26 +31,16 @@ class CustomTabBar extends React.Component<Props, State> {
static TAB_BAR_HEIGHT = 48; static TAB_BAR_HEIGHT = 48;
activeColor: string;
inactiveColor: string;
state = { state = {
translateY: new Animated.Value(0), translateY: new Animated.Value(0),
barSynced: false,// Is the bar synced with the header for animations? barSynced: false,// Is the bar synced with the header for animations?
} }
// shouldComponentUpdate(nextProps: Props): boolean {
// return (nextProps.theme.dark !== this.props.theme.dark)
// || (nextProps.state.index !== this.props.state.index);
// }
tabRef: Object; tabRef: Object;
constructor(props) { constructor(props) {
super(props); super(props);
this.tabRef = React.createRef(); this.tabRef = React.createRef();
this.activeColor = props.theme.colors.primary;
this.inactiveColor = props.theme.colors.tabIcon;
} }
onItemPress(route: Object, currentIndex: number, destIndex: number) { onItemPress(route: Object, currentIndex: number, destIndex: number) {
@ -119,7 +109,7 @@ class CustomTabBar extends React.Component<Props, State> {
} }
} }
const color = isFocused ? this.activeColor : this.inactiveColor; const color = isFocused ? this.props.theme.colors.primary : this.props.theme.colors.tabIcon;
if (route.name !== "home") { if (route.name !== "home") {
return <TabIcon return <TabIcon
onPress={onPress} onPress={onPress}